Disable git text conversion via .gitattributes, remove CI workarounds#187
Merged
emlowe merged 1 commit intoChia-Network:mainfrom Mar 4, 2026
Merged
Conversation
Add `* -text` to .gitattributes to prevent git from performing any line-ending conversion on any file. This makes the per-workflow `git config --global core.autocrlf false` step in precommit redundant, so remove it.
Quexington
approved these changes
Feb 19, 2026
Contributor
Author
|
https://github.com/Chia-Network/chia-dev-tools/actions/runs/22199207546/job/65476430517 was a wonky error. and i forgot that close and reopen would trigger run approval. sorry... |
Contributor
|
The pre-commit error is a bad cache afaict - if you update your branch from main, I added a comment to the precommit yaml to force a cache miss and this resolves the issue in other PRs Well maybe that isnt helping - somehow the pre-commit action cache is getting poisoned - I don't think there is a flag to turn it off though |
Contributor
|
Ah, i think maybe it's a runner problem |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
* -textto.gitattributesto disable git's automatic line-ending conversion for all filesgit config --global core.autocrlf falseCI step fromprecommit.ymlContext
Same change as Chia-Network/chia-blockchain#20514. The
.gitattributesattribute takes precedence overcore.autocrlf, so the CI workaround step is no longer needed — and the protection extends to all contributors' local environments too, not just CI.